palantir/blueprint

FR: Support small modifier for NumericInput

Open

#3,132 建立於 2018年11月7日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: coreType: feature requesthelp wanted

描述

Environment

  • Package version(s): 3.8
  • Browser and OS versions: Chrome 70

Feature request

I like to make a form using small modifier on components. I can use small modifier on InputGroup and Button but MenuItem and NumericInput does not support small modifier. I tried className={Classes.SMALL} but it did not work. You can look at screenshot below as an example

Could you implement support for these components? Probably there are other components that does not support small modifier. I prefer support for all components which can be used inside a form.

Examples

<Button small={true} rightIcon="double-caret-vertical" .../> <InputGroup small={true} .../> <NumericInput leftIcon="arrow-top-left" .../> // does not support small modifier <NumericInput .../>

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Blueprint component patternsUnderstanding of TypeScript and React
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests adding a 'small' modifier to NumericInput, similar to existing support in Button and InputGroup. Research the implementation of the 'small' prop in those components (e.g., Button.tsx and InputGroup.tsx) to understand the pattern. Then examine NumericInput.tsx and its associated styles in numeric input.scss to add the Small modifier. The issue mentions that className={Classes.SMALL} did not work, so the fix likely involves adding a prop or CSS class that applies the small size styling. There are no linked PRs or maintainer comments, so the implementation is straightforward and can follow the existing pattern.