palantir/blueprint

[Table] Feature Request: Add an onStartEditing event handler to EditableCell

Open

#2,682 建立於 2018年7月12日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Package: tableType: feature requesthelp wanted

描述

It would be quite helpful to have an onStartEditing event handler on EditableCell that takes a function that is passed a row and column. This allow would show additional custom elements (select, autocomplete and etc.).

Example: _add_on_edit

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of ReactFamiliarity with Blueprint's EditableCell component
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the EditableCell component source in the Blueprint repository to understand existing event handlers (onConfirm, onCancel). Implement a new onStartEditing prop that triggers when the cell enters edit mode. Look at how other cell event handlers pass row and column data. Check the issue comments for any additional requirements or discussion. The implementation should follow the pattern of existing handlers.
[Table] Feature Request: Add an onStartEditing event handler to EditableCell · palantir/blueprint#2682 | Good First Issue