palantir/blueprint

Proposal: Make icons multipath for more advanced CSS styling

Open

#2,389 建立於 2018年4月13日

在 GitHub 查看
 (32 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Package: iconsType: enhancementhelp wanted

描述

It would be great if icons that consist of multiple elements would have multiple paths, each with class name that could be used to style it (CSS).

For example: cloud-download would have 2 paths, one for cloud, one for down arrow. Each path would have it's own class name accessible using CSS for styling purposes.

貢獻者指南

技術棧
typescriptreactcss
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
SVG conceptsReactCSS styling of SVG
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Start by examining the current icon implementation in the Blueprint repository, likely in the 'icons' or 'icon' directory. Understand how each icon is defined as a React component and how paths are structured. The issue requests splitting icons like 'cloud download' into multiple paths (e.g., cloud shape and arrow) with distinct class names. Look at the existing icon generation script and SVG rendering code. Check the 32 comments for any proposed approaches or maintainer feedback. Consider how to add class names to individual paths without breaking existing usage.