palantir/blueprint

[DateTime] Decouple "Enter to close" from "closeOnSelection" for DateInput/DateRangeInput

Open

#1,988 建立於 2018年1月11日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P2Package: datetimeType: enhancementhelp wanted

描述

Feature request:

Allow more flexible control over when the popup closes for both DateInput and DateRangeInput

Currently, enter to close only works if "closeOnSelection" is true.

See also: #1825

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactBlueprint DateInput/DateRangeInput
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the DateInput and DateRangeInput components in the Blueprint repository (likely under packages/datetime/src). Look at the current implementation of closeOnSelection and the Enter key handler. Refer to the linked issue #1825 for context. The goal is to separate the Enter to close behavior from closeOnSelection, possibly adding a new prop like 'closeOnEnter'. Start by examining the component's internal state and event handling.