palantir/blueprint

[DateInput] DateInput re-opens after changing time

Open

#1,831 建立於 2017年11月21日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
P3Package: datetimeType: bughelp wanted

描述

Bug report

  • Package version(s): 1.33.0
  • Browser and OS versions: Chrome 62.0.3202.94, Firefox 57.0, Firefox 56.0 on Windows 10

Steps to reproduce

Reproducible on the documentation page for DateInput http://blueprintjs.com/docs/#datetime/dateinput

See a video of the bug here: https://youtu.be/3Z7MrvRJ0xU

  1. Set DateInput precision to Minute, so the TimePicker is shown
  2. Open the DateInput
  3. Change the time in the TimePicker, you need to actually set a new value, it seems
  4. Close the DateInput by clicking outside

Actual behavior

The DateInput will close and then immediately open again

Expected behavior

The DateInput will close

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the DateInput component's behavior when the TimePicker changes. Look at the file `packages/datetime/src/dateInput.tsx` for the `handleTimeChange` and `handleClose` methods. The bug suggests a race condition or event propagation issue causing the DateInput to reopen after clicking outside. Check if there's a focus related issue in the TimePicker or DateInput's popover. Also review the comments on the issue for additional context.