palantir/blueprint

EditableText: support additional editing customisation [feature request]

Open

#1,393 建立於 2017年7月27日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)TypeScript (20,263 star) (2,167 fork)batch import
Package: coreType: enhancementhelp wanted

描述

It would be convenient to have more control around the edit process.

My motivating example is to differentiate display-value vs edit-value; for example display a formatted currency string "$1,234.50", but present the raw number (1234.5) for editing.

I can think of a few possibilities off the top of my head to implement this:

  • an optional format function
  • different properties for display and editing values
  • a callback fired before editing starts
  • (more involved) a different component for editing, meaning you could also use a select list on edit, or a colour picker, etc

I'm not sure which might be the best solution, if this is desirable functionality, but I'm happy to work on a patch for feedback if necessary.

貢獻者指南

技術棧
reacttypescript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactTypeScriptBlueprint component patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Explore the EditableText component source in the Blueprint repository to understand current implementation. Evaluate the feasibility of the proposed approaches (format function, separate props, callback, etc.) considering backward compatibility. Check issue comments for maintainer preferences and any rejected or preferred solutions. Focus on implementing a simple format function or a callback before editing to start.