openzipkin/zipkin

Special case Elasticsearch 7.8+ Composable index templates

Open

#3,138 建立於 2020年7月6日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)Java (16,912 star) (3,079 fork)batch import
elasticsearchenhancementhelp wanted

描述

Feature: If we prefer composable templates or otherwise prioritize our index templates, we can avoid support problems like https://github.com/openzipkin/zipkin-support/issues/23 where the template doesn't kick in due to something else matching on '*'

Rational Composeable templates are both introduced and preferred in ES 7.8+, which refers to _template as legacy ones.

This would introduce an issue of composeable template priority, either it would have to determine automatically what value should be set or be parameterizable through env variable.

Example Scenario Test would have a pre-existing composable template and ours still applies

Thanks @benqs for the hint. cc @openzipkin/elasticsearch

貢獻者指南

技術棧
javaelasticsearch
領域
backenddatabase
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Elasticsearch index templatesZipkin storage conceptsJava
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Research Elasticsearch 7.8+ composable index templates and their priority mechanism. Examine the existing index template configuration in the Zipkin codebase (likely in the elasticsearch storage module). Consider how to detect ES version and either automatically use composable templates or provide an environment variable to enable them. There is no existing PR or maintainer comment to guide the implementation, so you may need to open a discussion thread to clarify the desired behavior.