openzfs/zfs

zfs holds -r does not work on non-snapshot datasets

Open

#9,822 建立於 2020年1月8日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C (9,908 star) (1,703 fork)batch import
Type: Defectgood first issue

描述

System information

Type Version/Name
Distribution Name Arch Linux
Distribution Version rolling
Linux Kernel 5.4.6
Architecture x86_64
ZFS Version 0.8.2-1
SPL Version 0.8.2-1

Describe the problem you're observing

If trying to list all of the holds on all of the snapshots on a dataset, I would expect zfs holds -r [dataset] to list, per snapshot, all of the holds. On FreeBSD 12.1 this works as expected. However, on ZFS on Linux it just says "not a snapshot" and lists nothing.

Describe how to reproduce the problem

  • Create a snapshot on a dataset
  • Create a hold on that snapshot
  • Run zfs holds -r [dataset]@[snapshot] and observe the hold
  • Run zfs holds -r [dataset] and observe the error

Include any warning/errors/backtraces from the system logs

N/A

貢獻者指南

技術棧
c
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingZFS command line toolsLinux/Unix system knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate the implementation of the 'zfs holds r' command in the ZFS source code, specifically in the 'cmd/zfs/zfs main.c' file. The issue mentions that the recursive flag does not work on non snapshot datasets, while it works on FreeBSD. Look for how the ' r' flag is processed and how the dataset argument is handled. Compare the Linux and FreeBSD implementations if available. Check the man page for expected behavior and verify if there is any existing comment or code comment regarding this discrepancy. The issue has no linked PRs, so the fix would involve modifying the argument parsing or iteration logic to include snapshots when the ' r' flag is used.