openzfs/zfs

zpool status - cache and spare names inconsistent

Open

#9,383 建立於 2019年9月30日

在 GitHub 查看
 (11 留言) (0 反應) (0 負責人)C (9,908 star) (1,703 fork)batch import
Bot: Not StaleType: Defectgood first issue

描述

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 18.04.2 LTS
Linux Kernel 4.15.0-48-generic
Architecture x86_64
ZFS Version 0.8.0-1
SPL Version 0.8.0-1

Describe the problem you're observing

The command zpool status shows cache and spare vdevs with Linux 'sd' style names when the device was added with vdev_id. For spares, this is maintained when the spare is used. The same may be true of log vdevs, I'm not sure.

Describe how to reproduce the problem

The spare has been activated in this case. Also note that we probably have a bad port/expander as we have had multiple drive failures in the same slot.

I expect to see 2:9 and 2:10 in the output, not sdai and sdah.

Output:


# zpool history nice_pool | grep -E '(cache|spare)'
2019-07-15.19:09:12 zpool add -f nice_pool spare 2:9
2019-07-15.19:09:13 zpool add -f nice_pool cache 2:10

# zpool status nice_pool
  pool: nice_pool
 state: DEGRADED
  scan: resilvered 2.67T in 0 days 21:52:48 with 0 errors on Sat Sep 28 13:44:33 2019
config:

	NAME               STATE     READ WRITE CKSUM
	nice_pool       DEGRADED     0     0     0
	  raidz3-0         DEGRADED     0     0     0
	    1:0            ONLINE       0     0     0
	    1:1            ONLINE       0     0     0
	    1:2            ONLINE       0     0     0
	    1:3            ONLINE       0     0     0
	    1:4            ONLINE       0     0     0
	    1:5            ONLINE       0     0     0
	    1:6            ONLINE       0     0     0
	    1:7            ONLINE       0     0     0
	    spare-8        DEGRADED     0     0     0
	      replacing-0  UNAVAIL      0     0     0  insufficient replicas
	        old        FAULTED      0    11     0  too many errors
	        old        FAULTED      0    46     0  too many errors
	        1:8        FAULTED      0    39     0  too many errors
	      sdah         ONLINE       0     0     0
	    1:9            ONLINE       0     0     0
	    1:10           ONLINE       0     0     0
	  raidz3-1         ONLINE       0     0     0
	    1:11           ONLINE       0     0     0
	    1:12           ONLINE       0     0     0
	    1:13           ONLINE       0     0     0
	    1:14           ONLINE       0     0     0
	    1:15           ONLINE       0     0     0
	    1:16           ONLINE       0     0     0
	    1:17           ONLINE       0     0     0
	    1:18           ONLINE       0     0     0
	    1:19           ONLINE       0     0     0
	    1:20           ONLINE       0     0     0
	    1:21           ONLINE       0     0     0
	  raidz3-2         ONLINE       0     0     0
	    1:22           ONLINE       0     0     0
	    1:23           ONLINE       0     0     0
	    2:0            ONLINE       0     0     0
	    2:1            ONLINE       0     0     0
	    2:2            ONLINE       0     0     0
	    2:3            ONLINE       0     0     0
	    2:4            ONLINE       0     0     0
	    2:5            ONLINE       0     0     0
	    2:6            ONLINE       0     0     0
	    2:7            ONLINE       0     0     0
	    2:8            ONLINE       0     0     0
	cache
	  sdai             ONLINE       0     0     0
	spares
	  sdah             INUSE     currently in use

errors: No known data errors

貢獻者指南

技術棧
c
領域
cli
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingZFS vdev naming
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
Investigate the zpool status command implementation in the ZFS source repository, focusing on how vdev names are displayed. Look for code that handles cache and spare vdevs specifically, likely in cmd/zpool/zpool main.c or lib/libzfs/libzfs pool.c. The issue is that vdev id mappings are not used for cache and spare devices. Examine the function that determines the display name and ensure it applies the same logic for all vdev types.