openzfs/zfs

vdev_add event does not include vdev info

Open

#7,107 建立於 2018年1月31日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C (9,908 star) (1,703 fork)batch import
Type: Featuregood first issue

描述

System information

Type Version/Name
Distribution Name CentOS Linux
Distribution Version 7 (Core)
Linux Kernel 3.10.0-693.5.2
Architecture x86_64
ZFS Version 0.7.5-1
SPL Version 0.7.5-1

Describe the problem you're observing

consider zpool add tank /virtualfs2

this emits an event like:

IFS= 	
PATH=/usr/bin:/bin:/usr/sbin:/sbin
PWD=/
SHLVL=1
ZDB=/sbin/zdb
ZED=/sbin/zed
ZED_PID=26595
ZED_ZEDLET_DIR=/etc/zfs/zed.d
ZEVENT_CLASS=sysevent.fs.zfs.vdev_add
ZEVENT_EID=215
ZEVENT_POOL=tank
ZEVENT_POOL_CONTEXT=0
ZEVENT_POOL_GUID=0x576058F099B118E7
ZEVENT_POOL_STATE=0
ZEVENT_POOL_STATE_STR=ACTIVE
ZEVENT_SUBCLASS=vdev_add
ZEVENT_TIME=1517416348 27179838
ZEVENT_TIME_NSECS=27179838
ZEVENT_TIME_SECS=1517416348
ZEVENT_TIME_STRING=2018-01-31 11:32:28-0500
ZEVENT_VERSION=0
ZFS=/sbin/zfs
ZFS_ALIAS=zfs-0.7.5-1
ZFS_RELEASE=1
ZFS_VERSION=0.7.5
ZINJECT=/sbin/zinject
ZPOOL=/sbin/zpool
_=/usr/bin/printenv

I would expect this event to contain VDEV related info like ZEVENT_VDEV_PATH.

貢獻者指南

技術棧
c
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingZFS event subsystemvdev structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
15
研究方向
Investigate the ZFS event generation code to identify where vdev add events are constructed. Compare with vdev remove or other events that already include ZEVENT VDEV PATH. The relevant files are likely in module/zfs/ such as spa.c or vdev.c. Add the missing field by following the pattern used for similar events. Confirm that the vdev path is available at the point of event posting.