openwall/john

Have some *2john programs explain that it's normal to have large output

Open

#4,051 建立於 2019年7月19日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C (8,833 star) (1,997 fork)batch import
documentationenhancementgood first issue

描述

Our users are often confused by the output from programs such as zip2john sometimes being very large (multi-gigabyte). Maybe we should identify and enhance these programs to output a message to stderr to explain to users that it's normal for the output to be very large - maybe always or maybe only when the output size is above a threshold (e.g., 1 million bytes?)

貢獻者指南

技術棧
c
領域
clideveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C programmingunderstanding of stderr
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Look at the source code for programs like zip2john (e.g., src/zip2john.c) to understand where the output is generated. Add a conditional check on output size (e.g., after computing the hash) and use fprintf(stderr, ...) to inform the user that large output is normal. Consider implementing a threshold (e.g., 1 MB) before printing the message to avoid unnecessary warnings for small outputs. Check if there are existing similar messages in other *2john programs to maintain consistency.