openssl/openssl

Strange code styl in crypto/s390xcap.c after reformatting in WebKit style

Open

#31,247 建立於 2026年5月20日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C (30,157 star) (11,262 fork)batch import
help wantedtriaged: cleanuptriaged: refactor

描述

The entire code block below the comment /* query function tokens */ (lines 521-534) looks strange: https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/crypto/s390xcap.c#L520

Not only the long chain of if .. elseif ... in single lines look strange, but especially the block at line 532 seems to be misaligned IMHO: https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/crypto/s390xcap.c#L532

Is this as intended as-is, or is there a way to make this better readable?

貢獻者指南

技術棧
c
領域
securitybackend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic C knowledgecode formatting tools
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
Examine the code block at lines 521-534 in crypto/s390xcap.c to understand the current formatting. Review the project's coding style guidelines (e.g., WebKit style) to determine the intended formatting. Check the history of the file to see if the formatting was introduced by a recent commit. Discuss with maintainers via the issue comments whether they prefer the current style or a reformatted version.