opensearch-project/OpenSearch

Docker is required to build

Open

#1,406 建立於 2021年10月21日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Java (1,505 fork)batch import
bughelp wanted

倉庫指標

Star
 (8,123 star)
PR 合併指標
 (平均合併 5天 9小時) (30 天內合併 266 個 PR)

描述

Is your feature request related to a problem? Please describe.

Coming from https://github.com/opensearch-project/OpenSearch/issues/1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.

Describe the solution you'd like

Skip distribution:docker* if docker is not available.

Additional context

Docker (checked [/usr/bin/docker, /usr/local/bin/docker, C:\Program Files\Docker\Docker\resources\bin\docker.exe]) is required to run the following tasks:
:distribution:docker:buildArm64DockerImage
:distribution:docker:buildDockerImage
you can address this by attending to the reported issue, or removing the offending tasks from being executed.

To reproduce, return null from DockerSupportServices.java, private Optional<String> getDockerPath() or run on Windows.

Current workaround:

$ ./gradlew build -x ":distribution:docker:buildArm64DockerImage" -x ":distribution:docker:buildDockerImage"

貢獻者指南