Criteria for Otel to Zipkin remoteEndpoint transformation should be broadened
#1,560 建立於 2021年3月18日
倉庫指標
- 星標
- (4,267 顆星)
- PR 合併指標
- (平均合併 10天 15小時) (30 天內合併 43 個 PR)
描述
The current Otel <-> Zipkin span mapping specifies that Zipkin's remoteEndpoint should be specified if Zipkin's SpanKind resolves to either SpanKind.CLIENT or SpanKind.PRODUCER, but omits SpanKind.CONSUMER.
If Zipkin SpanKind resolves to either SpanKind.CLIENT or SpanKind.PRODUCER then the service SHOULD specify remote endpoint otherwise Zipkin won't treat the Span as a dependency. peer.service is the preferred attribute but is not always available. The following table lists the possible attributes for remoteEndpoint by preferred ranking:
Per discussion in https://github.com/open-telemetry/opentelemetry-specification/discussions/1546 , this should be broadened to omit any specific SpanKind, and instead require that remoteEndpoint be populated wherever possible regardless of SpanKind.
It remains a SHOULD because there will still be cases where connections from things such as Unix domain sockets will not necessarily have a way to map to remoteEndpoint.