open-telemetry/opentelemetry-dotnet
Improve instrument name validation and log messages
開放
#2,532 建立於 2021年10月27日
enhancementhelp wantedkeep-openmetrics
倉庫指標
- 星標
- (3,725 顆星)
- PR 合併指標
- (平均合併 3天 17小時) (30 天內合併 112 個 PR)
描述
In PR #2470 we added validation for instrument and view names according to the spec. This issue is to track a small follow up that came up from PR comments :
- Use guard helpers: https://github.com/open-telemetry/opentelemetry-dotnet/pull/2470#discussion_r737044427
- Improve the message, specifying what was the original invalid name (instrument or view) https://github.com/open-telemetry/opentelemetry-dotnet/pull/2470#discussion_r737045347