open-duelyst/duelyst

Game gifs - hero & map - does not render if the screen size is too small

Open

#290 建立於 2023年5月31日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (3,443 star) (526 fork)batch import
bugfrontendhelp wanted

描述

Summary

When the screen is too small, the assets don't load in the game, this includes the map and the characters such as heros & character gifs, making it not really possible to play.

Impacted services

  • The frontend app

Steps to reproduce

  1. Start a local server and open the game in the chrome browser.
  2. Open the chrome inspector and use the device toolbar to use Pixel 4 dimensions, 353 * 745 in the webapp.
  3. Restart the game
  4. Load a practice match

The map does not render in the game & the heros don't load. (This also happens if you open the webapp on a phone like Pixel 6). Expected behaviour is that the characters load.

Environment information

  • Operating system: E.g. Linux
  • Browser: E.g. Chrome or Safari (could repro in both)

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the asset loading mechanism in the frontend, particularly how map and hero gifs are rendered. Check for any responsive CSS or JavaScript that conditionally loads assets based on screen size. Look at files like src/components/GameBoard.js or similar CSS media queries. The issue may be caused by missing breakpoints or incorrect handling of small screen dimensions.