open-duelyst/duelyst

[P3] Repair and re-enable disabled SDK unit tests

Open

#25 建立於 2022年9月10日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (3,443 star) (526 fork)batch import
backendenhancementfrontendhelp wanted

描述

Several unit tests have been disabled until we have time to go back and update them. search for Test disabled in the repo to find them:

% git grep -l 'Test disabled'
test/unit/sdk/ai/ai.js
test/unit/sdk/ai/bosses.js
test/unit/sdk/cards/bloodstorm/faction6.js
test/unit/sdk/cards/bloodstorm/neutrals.js
test/unit/sdk/cards/core/faction2/artifacts.js
test/unit/sdk/cards/core/faction3/minions.js
test/unit/sdk/cards/core/faction5/spells.js
test/unit/sdk/cards/core/neutrals/epics.js
test/unit/sdk/cards/coreshatter/faction1.js
test/unit/sdk/cards/misc/bloodborn_spells.js
test/unit/sdk/cards/monthlies/month7.js
test/unit/sdk/cards/monthlies/month9.js
test/unit/sdk/cards/monthlies/seven_sisters.js
test/unit/sdk/cards/shimzar/battle_pets.js
test/unit/sdk/cards/shimzar/faction1.js
test/unit/sdk/cards/shimzar/faction2.js
test/unit/sdk/cards/shimzar/faction4.js
test/unit/sdk/cards/shimzar/faction5.js
test/unit/sdk/cards/unity/faction5.js
test/unit/sdk/cards/unity/faction6.js
test/unit/sdk/cards/wartech/faction2.js
test/unit/sdk/cards/wartech/faction3.js
test/unit/sdk/cards/wartech/faction4.js
test/unit/sdk/cards/wartech/faction5.js
test/unit/sdk/game/basic.js

We should revisit these and turn them back on once we get them working.

貢獻者指南

技術棧
javascript
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScript programmingUnit testing experienceNode.js environment setup
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
First, use git grep to locate files containing 'Test disabled' as listed in the issue (e.g., test/unit/sdk/ai/ai.js). For each file, examine the disabled test(s) and understand the logic. Look for comments or recent changes that caused the test to fail. Update the test code to fix any issues and remove the 'Test disabled' marker. Ensure all tests pass. The repository uses JavaScript and likely a testing framework like Mocha or Jest—check package.json for details. No linked PRs or assignees exist, so this is open for taking.