onivim/oni

Textmate Highlighting: Visual mode selection does not have correct background

Open

#2,629 建立於 2018年10月12日

在 GitHub 查看
 (0 留言) (2 反應) (0 負責人)TypeScript (11,389 star) (336 fork)batch import
help wantedinsider

描述

Reported by @josemarluedke on discord.

Oni Version: v0.3.7 Operating System: Windows

Issue:

With textmate highlighting active, you see this: image

And he also tested out gruvbox dark: image

On my machine / config with gruvbox_dark, I see this: image

Steps to reproduce:

  • This reproduces both with gruvbox_dark and dracula themes

There's potentially an issue with how we're synchronizing colors / schemes to Neovim.

貢獻者指南

技術棧
typescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of textmate grammar highlightingFamiliarity with Neovim color scheme synchronization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Investigate how textmate colors are being synchronized to Neovim in the Oni codebase. Look at the color scheme handling code, possibly in files related to textmate or Neovim integration. The screenshots show incorrect background in visual mode, so the issue might be in how the 'Visual' highlight group is being mapped. Check recent changes or existing issues about color synchronization.