onivim/oni

Allow wildcards in bookmarks

Open

#2,562 建立於 2018年9月10日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)TypeScript (11,389 star) (336 fork)batch import
Feature-requestgood first issueinsider

描述

Currently, Oni bookmarks are defined as an array like so:

"oni.bookmarks": ["/home/ryan/git/oni", "/home/ryan/git/uni", "/home/ryan/git/dotfiles"...]

What would be nice is some form of wildcard expansion/globbing such that instead a user could do:

"oni.bookmarks": ["/home/ryan/git/*"]

And then add every git project say, or all projects in a folder and so on.

I think this would just be a case of hooking up some logic over in BookmarksSearch.ts to expand the wildcard in the constructor where we grab all bookmarks. There is some discussion of this over in #2554, including a package we could use.

We'd most likely want to restrict this to absolute paths only, so a users home dir isn't used etc.

貢獻者指南

技術棧
typescript
領域
frontendtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptNode.jsglobbing patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Start by examining the file 'BookmarksSearch.ts' to understand how bookmarks are currently loaded and stored. Look at the discussion in issue #2554 for suggested packages like 'glob' or 'minimatch'. Implement wildcard expansion in the constructor where bookmarks are gathered, ensuring only absolute paths are expanded.