onivim/oni

Feature - Command Palette: Allow specifying arguments for commands

Open

#1,960 建立於 2018年3月28日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (11,389 star) (336 fork)batch import
enhancementhelp wantedinsider

描述

This came up in the context of #1947 - it'd be really convenient when opening a browser window to specify a URL, directly from the command palette:

For example, if I start typing bro and then a space and then http://onivim.io, that would make opening a web browser much more convenient.

Today, we can't do that, since our fuzzy filtering tries to match the whole search string: args-to-command

To implement this, we might need to add a custom filter strategy for the command palette window (such that it only uses the first token in the string), and then update the Tasks provider (which backs the command palette) to send back any arguments. That code is around here: https://github.com/onivim/oni/blob/8186d0ba5754282b81464748355ad702d5a4f8e5/browser/src/Services/Tasks.ts#L78

貢獻者指南

技術棧
typescriptelectron
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptOni development setup
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Research the current command palette implementation, particularly the fuzzy filter in the Tasks provider at browser/src/Services/Tasks.ts. Understand how commands are matched and executed. Consider adding a custom filter strategy that only uses the first token for matching, and pass the remaining tokens as arguments to the command. Also review any existing tests for command palette to ensure no regressions.