onivim/oni

When tabs.mode == "buffers", moving/closing tabs is broken

Open

#1,768 建立於 2018年3月10日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (11,389 star) (336 fork)batch import
bughelp wanted

描述

I recently fixed the issue for tabs mode, but it seems like there is another bug affecting the tabs when in buffers mode.

How to reproduce:

  • Open a folder with 5-6 files
  • Open all the files as tabs
  • Attempt to select each one of them

What happens:

  • At some point it becomes impossible to select a tab
  • Even though tabs are not displayed as select, the Neovim editor still displays the content of the file clicked

Screen recording

貢獻者指南

技術棧
typescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
TypeScriptOni tab system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the tab selection logic for `buffers` mode in Oni. Look for the previous fix for `tabs` mode (mentioned in the issue) and identify differences. Check the codebase for tab related components. Since no comments or PRs exist, start by reproducing the bug and examining the tab state management code.