onivim/oni

TypeScript: Hook up auto-import functionality

Open

#1,593 建立於 2018年2月21日

在 GitHub 查看
 (12 留言) (3 反應) (1 負責人)TypeScript (11,389 star) (336 fork)batch import
bountybounty-100enhancementhelp wanted

描述

Splitting out from #1326 - integrate 'auto-import' functionality from TypeScript. This should generalize to other completion providers, too.

  • Implement additionalTextEdits and textEdit for CompletionItems as defined by the completion request in the language server protocol: https://microsoft.github.io/language-server-protocol/specification
  • Update our TypeScriptServerHost to send additionalTextEdits for auto-imports. This will involve settting the includeExternalModuleExports for the completions request, hooking up entry details resolution to get information about the additional code actions as part of the details request, and resolving those code actions to text edits. Looks like we'll need to plumb the 'source' through somehow, as this is needed when calling to get details.

貢獻者指南

技術棧
typescript
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic understanding of TypeScriptFamiliarity with Language Server Protocol
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Review the LSP completion specification for additionalTextEdits and textEdit. Examine the TypeScriptServerHost code to understand current completion handling and how to set the includeExternalModuleExports flag. Check issue #1326 for context on auto import integration and investigate how to resolve code actions to text edits, possibly by plumbing the 'source' through the completion details request.