Thoughts on the new global search · onivim/oni#1553

(3 留言) (3 反應) (0 負責人)TypeScript (11,389 star) (336 fork)batch import

enhancementhelp wanted

描述

Hi all, I just updated to 0.3.0 which has the new "VS Code" style sidebar with global search and I wanted to give my input about an alternative implementation (I sincerely hope that no one takes any offence to this).

I personally prefer the approach to global search that emacs-helm, atom-narrow and unite.vim take. The advantages of this style of approach include:

You get a consistent UI for narrowing lists of different types of data sources instead of a specific UI for just global line-wise search (i.e. ripgrep). For example, with the tools listed above you can use to same UI for local symbol search, global symbol search, global line-wise search, local line-wise search, local folds and more
It can be made to be extensible (just like how you can add your own custom sources with unite.vim)
Quicker to visually parse because the input text field is co-located with the results
This last point is quite opinionated, but I also feel that this approach is more "vim-like"

Looking forward to hearing your thoughts on this :)

貢獻者指南

技術棧: typescript
領域: design
議題類型: research
難度: 5
預計時間: over 1 week
活動狀態: stale
清晰度: unclear
前置要求: 無
新手友善度: 20
研究方向: This issue is a feature request to explore alternative UI approaches for global search, similar to emacs helm, atom narrow, and unite.vim. The discussion in the comments may provide additional context or maintainer feedback. To move forward, one should review Oni's current search implementation, understand its extensibility, and propose a design that unifies different search sources (e.g., symbols, lines, folds). The maintainers might have specific requirements or constraints that need to be addressed.