onivim/oni

Error Handling: Startup

Open

#1,383 建立於 2018年1月28日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (11,389 star) (336 fork)batch import
enhancementhelp wantedinsider

描述

This is tracking adding some better error-handling in startup, to give the user feedback when there is an issue on startup. Coming from @Akin909 's comments in #1381:

A solution to this is that the changeDir function should always check that the directory it is passed is valid before attempting to switch to it. A more general issue is that I think every function or rather main startup process should have a try/catch or some form of error handling so that oni doesn't end up hanging without any feedback given back to the user

We should do the following:

  • Wrap our 'start' call in a try/catch so that we can get errors
  • Have some UI affordance for showing an error UI (perhaps in Shell?). This could show any errors logged, as well as give the option for opening up a debug window. We could also potentially show an error notification once #1358 is in.

貢獻者指南

技術棧
typescriptreactelectron
領域
frontenddesktop
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScript basicsOni startup codeReact/UI components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Start by reviewing comments in issue #1381 for context on the changeDir function and error handling gaps. Look at the current 'start' function in the main process (likely in src/index.ts or similar). Examine the Shell component for potential error UI integration. Consider implementing a try/catch around the start call and displaying errors via a notification system similar to #1358.