olistic/warriorjs

Check if unit is alive after effects

Open

#63 建立於 2018年5月8日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)JavaScript (9,168 star) (528 fork)batch import
good first issuepkg: corestatus: claimedtype: enhancement

描述

A negative effect could potentially kill a unit. We need to check if the unit is still alive after executing the effects and return early if the unit died. Example: a "poisoned" effect (it doesn't exist, at least yet) that damages the unit turn by turn.

貢獻者指南

技術棧
javascript
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with WarriorJS game logicUnderstanding of Unit.js effects execution
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Examine the Unit.js file in packages/warriorjs core/src, specifically the method that executes effects around line 98. Understand the current flow and add a check after calling the effects to verify the unit's health. If health is 0 or below, cause the unit to die or return early. This is a small localized change.