ocaml/dune

Flush output buffers on SIGTERM

開放

#3,882 建立於 2020年10月21日

 (12 則留言) (0 個反應) (2 位負責人)OCaml (478 個分叉)github user discovery
good first issue

倉庫指標

星標
 (1,882 顆星)
PR 合併指標
 (平均合併 1天 20小時) (30 天內合併 345 個 PR)

描述

We're currently using dune runtest in OCaml-CI as the standard way of running tests for a package. If some of the tests for a package get stuck in a deadlock, the CI job will kill the process after 60 minutes. Unfortunately, this means that the logs of the stalled test run are lost.

We could switch to using dune runtest --no-buffer in the CI, but this creates less readable (interleaved) test output. One possible alternative would be for Dune to flush its output buffers before responding to SIGTERM (probably keeping the old behaviour for SIGKILL). What do you think?

貢獻者指南