nspcc-dev/neofs-node

node: Refactor using `StorageEngine` in `Object` service

開放

#1,834 建立於 2022年10月4日

 (0 則留言) (0 個反應) (0 位負責人)Go (49 個分叉)auto 404
I4S2U4enhancementgood first issueneofs-storage

倉庫指標

星標
 (36 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Object service server of storage node uses engine.StorageEngine type directly almost everywhere. Such code architecture doesn't allow to tune local storage behavior. For example, in #1798 there was a need to block all local operations, but on Object server only: Control service should still call the engine.

I propose to refactor engine's usage as it done it ObjectService.Put server

https://github.com/nspcc-dev/neofs-node/blob/4eb0ed11f8e56beee3dfbee632cb4b9cad3bb47c/pkg/services/object/put/local.go#L11-L16

Each component should precisely document expected behavior of local object storage by itself via locally defined interface. As a bonus, instance can be easily mocked for testing.

貢獻者指南