nodejs/node

test_runner: do not read from `process.argv` and `process.cwd()` in run()

Open

#53,867 建立於 2024年7月16日

在 GitHub 查看
 (13 留言) (5 反應) (0 負責人)JavaScript (117,218 star) (35,535 fork)batch import
good first issuetest_runner

描述

Currently the codebase for https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/test_runner/runner.js#L472 accesses some poperties of process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/main/test_runner.js#L68 and pass it down to run() as options.

貢獻者指南

技術棧
javascriptnodejs
領域
backendtesting
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of Node.js internalsknowledge of process.argv and process.cwd()familiarity with test runner module
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The issue requires moving the capture of process.argv and process.cwd() from runner.js to test runner.js and passing them as options to run(). Examine the code in lib/internal/test runner/runner.js around line 472 and lib/internal/main/test runner.js around line 68 to understand current usage. Ensure that all dependencies on process properties are relocated and passed as parameters. No linked PRs or additional context in comments.