nodejs/node

Re-enable test-ubsan.yml

已關閉

#52,753 建立於 2024年4月29日

 (2 則留言) (0 個反應) (0 位負責人)JavaScript (35,535 個分叉)batch import
help wantedmetastale

倉庫指標

星標
 (117,218 顆星)
PR 合併指標
 (平均合併 18天 17小時) (30 天內合併 219 個 PR)

描述

During the latest Node.js major release (https://github.com/nodejs/node/pull/52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (https://github.com/nodejs/node/pull/52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

  • It seems clang provides a better output and some docs we could use in the suppressions file.
    • Changing from g++ to clang for UBSAN will require changing all the suppression file

貢獻者指南