nodejs/node

Writable does not check if stream has been destroyed during _final and _write

Open

#39,030 建立於 2021年6月14日

在 GitHub 查看
 (21 留言) (1 反應) (0 負責人)JavaScript (117,218 star) (35,535 fork)batch import
good first issuesemver-majorstream

描述

Not sure if this is a problem but I think we should at least add a comment in the code that this case has been considered.

貢獻者指南

技術棧
javascriptnodejs
領域
backenddocumentation
議題類型
documentation
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of Node.js streams
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Examine the source file `lib/ stream writable.js` in the Node.js repository, focusing on the ` write` and ` final` methods. Look for any existing checks for `destroyed` state and comments. The issue requests adding a comment to clarify the behavior when the stream is destroyed during these calls. Review the discussion in the issue comments for any specific concerns or suggested wording. Ensure the comment is added in the appropriate location within each method.