nodejs/node

[C++ Lint Rule] #define indentation is Inconsistent

已關閉

#28,605 建立於 2019年7月9日

 (4 則留言) (1 個反應) (0 位負責人)JavaScript (35,535 個分叉)batch import
c++help wantedstale

倉庫指標

星標
 (117,218 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

I was recently going through the source code, trying to familiarize myself with the codebase, and I noticed that there's no consistent rule for how #defines are indented.

For example, in node_main.cc, there's no indentation at all in this #ifdef block.

However, in other places, like node.h, there's a space between the # and the define to indicate a kind of indentation.

There also seems to be inconsistency with how many spaces/tabs should go after the #define variable name and the value, as seen here.

Can we come up with a rule for this and add it to the C++ Style Guide? Maybe even add a rule to the linter?

To get started with the rules we can to define, some questions are:

  1. Should #defines inside of braces be indented?
  2. When should #ifdef X be used vs. if defined(X)?
  3. What should the indentation pattern be for #define/#ifdef/#if defined/#ifndef?

貢獻者指南