nodejs/node

Run tests with OPENSSL_CONF set to embedded openssl.cnf

Open

#24,373 建立於 2018年11月15日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (117,218 star) (35,535 fork)batch import
help wantedopenssltest

描述

  • Version: <= 10.13.0
  • Platform: Linux

when building with the --shared-openssl flag, it is highly probable that the openssl.cnf used by the shared library will be different than the one present in Node.js source code, resulting in several test failures. Typically, on debian, openssl is configured with stricter options regarding key length and TLS versions. It is very easy to avoid any test failure, though, by setting this environment variable when running tests: OPENSSL_CONF=./deps/openssl/openssl/apps/openssl.cnf

貢獻者指南

技術棧
nodejsjavascript
領域
testingbackend
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of Node.js test suiteBasic knowledge of OpenSSL configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue suggests setting the OPENSSL CONF environment variable to the embedded openssl.cnf file when running tests with shared openssl. This can be implemented by modifying the test runner configuration, possibly in the Makefile or test scripts. Look at the test configuration files in the repository, such as 'Makefile' or 'test/common/' to add the environment variable.