nodejs/llnode

Apply env variables to test timeouts consistently

開放

#407 建立於 2022年8月20日

 (0 則留言) (0 個反應) (0 位負責人)C++ (101 個分叉)github user discovery
good first issuehelp wanted

倉庫指標

星標
 (1,167 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

The test suite currently defines a session timeout for tests based on process.env.TEST_TIMEOUT https://github.com/nodejs/llnode/blob/main/test/common.js#L173 This timeout has recently been incremented due to the restricted resources in GH Actions.

The timeout also isn't applied to all the tests and some have been overridden directly in the code base for longer tests. https://github.com/nodejs/llnode/blob/ff75da7eb151cf8d7481eba9a1c6406a53c85ce5/test/plugin/workqueue-test.js#L29

A suggested approach is to have process.env.TEST_TIMEOUT and a new process.env.TEST_TIMEOUT_LONG consistently applied across the project so that the GH Actions can be incremented without modifying code and local development can shorten a test run by decreasing the same environment variables on the local machine.

貢獻者指南