nicfit/eyeD3

allow to set multiple TCON frames

Open

#296 建立於 2018年12月15日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (487 star) (58 fork)batch import
featurehelp wanted

描述

Setting multiple TCON frames logs all modification, but then only the last frame is written

$ eyeD3 --text-frame=TCON:Rock --text-frame=TCON:Ballad \
     --text-frame=TCON:Pop /tmp/1.mp3

Setting b'TCON' text frame to 'Rock'
Setting b'TCON' text frame to 'Ballad'
Setting b'TCON' text frame to 'Pop'

The situation is different if the file had multiple TCON frames in origin. Only the first is modified while others frames are kept.

Further info in debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887405

Tested with eyed3 0.8.7 and python 3.6.7.

貢獻者指南

技術棧
python
領域
clitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of ID3 tagsPython programming
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
Investigate the code that handles writing multiple TCON frames. The issue states that when multiple TCON frames are set via command line, only the last one is written. Look at the relevant functions in eyeD3 that process and write text frames, possibly in the tag writing module. Check the linked Debian bug for additional context. Focus on how frames are collected and how duplicate frames are handled. Consider adding support for multiple frames of the same type or modifying the existing logic to write all provided frames.