nfl/react-helmet

Unexpected comma in title

Open

#408 建立於 2018年10月9日

在 GitHub 查看
 (9 留言) (6 反應) (0 負責人)JavaScript (17,167 star) (706 fork)batch import
bughelp wanted

描述

Similar to #286, I continue to see a comma in the title of pages of my Gatsby app and seems to only be a problem if there's an expression in the title. A reproduction of this issue can be seen in the following branch.

https://github.com/corydeppen/gatsby-8655-example/tree/react-helmet-comma

貢獻者指南

技術棧
reactjavascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactJavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the reproduction branch at https://github.com/corydeppen/gatsby 8655 example/tree/react helmet comma to reproduce the issue. Examine the React Helmet source code, particularly how the title prop is processed and concatenated, to identify where an extra comma is inserted. Check if the bug is related to how expressions in the title are handled, possibly in the side effects or rewrite methods.