nfl/react-helmet

Move typespec to this repo

Open

#358 建立於 2018年2月25日

在 GitHub 查看
 (1 留言) (3 反應) (0 負責人)JavaScript (17,167 star) (706 fork)batch import
enhancementgood first issuehelp wanted

描述

Is there any reason why we can't move the typespec from https://github.com/DefinitelyTyped/DefinitelyTyped to this repo so we do not have to deal with two packages.

We could copy that into this package and add "types": "./lib/main.d.ts" in the package.json

貢獻者指南

技術棧
typescriptreact
領域
developer experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with TypeScript type definitionsUnderstanding of npm package.json
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
First, find the existing type definitions in DefinitelyTyped for react helmet (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react helmet). Copy the relevant .d.ts files into this repo, e.g., into a 'types' directory. Then, update package.json by adding a 'types' field pointing to the new declaration file (e.g., "./lib/main.d.ts"). Ensure the types align with the current API. Check the issue comments for any maintainer feedback.
Move typespec to this repo · nfl/react-helmet#358 | Good First Issue