nextcloud/server

Enable usage of svg favicons and remove imagick from iconbuilder

Open

#36,607 建立於 2023年2月8日

在 GitHub 查看
 (11 留言) (4 反應) (0 負責人)PHP (34,953 star) (4,865 fork)batch import
1. to developfeature: theminghelp wantedtechnical debt

描述

This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.

Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons

cc @juliushaertl

貢獻者指南

技術棧
php
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PHPNextcloud server architectureTheming app concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
The issue involves enabling SVG favicons in the iconbuilder of the theming app and removing the imagick dependency. The code is likely in the 'theming' app directory. Review the linked blog post about Safari SVG favicon support. Check comments for any ongoing work or additional requirements. Ensure that the replacement using gd and imaginary handles all icon types. No linked PRs exist, so implement the changes from scratch, testing with various browsers.