nextcloud/android

status dialog: not able to set only "icon" / only "clear at"

Open

#9,855 建立於 2022年2月17日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)Java (3,752 star) (1,719 fork)batch import
approvedbugfeature: statusgood first issue

描述

Steps to reproduce

  1. set only icon or only clear at without to enter status message
  2. click set staus

Expected behaviour

  • icon or clear at are set

Actual behaviour

  • icon or clear at not set

Environment data

Nextcloud app version: 3.19.0

solution

api seems to set single modification for icon or "clear at" only if status message is not empty (must be at least whitespace)

see android talk commit https://github.com/nextcloud/talk-android/pull/1668/commits/a89c5952fa2747c8877c7882a6106311257722bf

貢獻者指南

技術棧
javaandroid
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Android development basicsJava
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue is about setting only icon or clear at without a status message in the Nextcloud Android app. The expected behavior is that setting just the icon or clear at should work, but the API currently requires a non empty status message (at least whitespace). A similar fix was applied in the Android Talk app: see commit a89c5952fa2747c8877c7882a6106311257722bf. The solution likely involves modifying the API call in the status dialog to handle cases where status message is empty. Look at the status dialog implementation in the Nextcloud Android repository for the relevant network request code.