ndelvalle/v-click-outside

The isActive config is ignored when updated dynamically

Open

#143 建立於 2019年11月8日

在 GitHub 查看
 (2 留言) (0 反應) (1 負責人)JavaScript (959 star) (90 fork)batch import
bughelp wanted

描述

I'm trying to disable the behavior of the click outside dynamically by changing the isActive property of the config object but the behavior still the same.

I know I can use the middleware to handle this (check line 36) but I don't know if the config of click outside expects to be dynamically.

https://codesandbox.io/s/v-click-outside-e4vin

貢獻者指南

技術棧
javascriptvue
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of Vue reactivityFamiliarity with Vue directives
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
The issue is that the `isActive` property in the config object is not being observed when changed dynamically. The fix likely involves adding a watcher or recomputing the directive's behavior when `isActive` changes. Check the source file `src/directive.js` for how the config is bound and if there's a mechanism to react to changes. The CodeSandbox linked in the issue (https://codesandbox.io/s/v click outside e4vin) demonstrates the problem. The assignee might have insights; review any existing comments or PRs for potential solutions.