nasa/sample_app

First parameter to `add_cfe_tables` should be app name

開放

#148 建立於 2021年5月17日

 (0 則留言) (0 個反應) (1 位負責人)C (61 個分叉)auto 404
build-systemgood first issue

倉庫指標

星標
 (64 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Describe the bug The add_cfe_tables function is declared as follows in arch_build.cmake: function(add_cfe_tables APP_NAME TBL_SRC_FILES)

The first parameter was intended to be the application name that the table is associated with, but historically any string was accepted since the string just served to make a unique target name.

To Reproduce Sample_app always passes the string sampleAppTable here.

Expected behavior Should pass sample_app as first argument.

Code snips https://github.com/nasa/sample_app/blob/1c32ed48ca358a3fdd55f1bdc9ae0dda61a4f4f7/CMakeLists.txt#L14

System observed on: Ubuntu

Additional context No major issue with the current build system, but will may become an issue if/when nasa/cfe#1538 is implemented, and may also become an issue if directory-scope include directories are removed.

Reporter Info Joseph Hickey, Vantage Systems, Inc.

貢獻者指南