nannou-org/nannou

Fix orientation of teapot in `wgpu_instancing.rs` after update to 0.5

Open

#596 建立於 2020年5月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Rust (4,662 star) (254 fork)batch import
buggood first issue

描述

I just realised that I forgot to correct the orientation of the teapot in this example to account for wgpu's switch to having the y axis increase upwards (rather than downwards). Previously the teapot examples all used a view matrix with an inverted axis in order to account for the downwards y axis, as the original teapot vertices were intended for an upward y axis. This has been correct in the wgpu_teapot* examples in #594, but I forgot to correct it in wgpu_instancing.rs. This is a reminder to myself (or anyone) to fix it.

貢獻者指南

技術棧
rust
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rustwgpucoordinate systems
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue is in the file `wgpu instancing.rs`. The fix involves adjusting the view matrix or the teapot's vertices to account for wgpu's y axis upward convention, as done in PR #594 for other teapot examples. Refer to that PR for the correct approach. The change is localized and well understood.