musescore/MuseScore

Fretboard diagram properties: Accept T, t, P, and p as valid fingerings

Open

#23,755 建立於 2024年7月24日

在 GitHub 查看
 (3 留言) (0 反應) (2 負責人)C++ (11,122 star) (2,432 fork)batch import
P3UX/interactioncommunityengravinggood first issue

描述

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

Currently, only numeric characters 1-5 are valid entries for fingerings on fretboard diagrams. "T" and "t" should also be accepted, to indicate "thumb" (example below) as well as "P" and "p" for pulgar as pointed out here.

image

Supporting files, videos and screenshots

I should be able to enter "T" in this box.

What is the latest version of MuseScore Studio where this issue is present?

4.4 Nightly

Regression

No.

Operating system

macOS 14.5

Additional context

No response

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

貢獻者指南

技術棧
cpp
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the validation logic for fretboard diagram fingerings in the MuseScore source code. The code currently only accepts numeric 1-5; locate the validation function (likely in a file related to fretboard diagrams, e.g., 'fretboard.cpp'). Modify it to accept 'T', 't', 'P', and 'p' as valid inputs. Ensure consistent handling of case and update any related UI hints if present.