mumble-voip/mumble

Iterate through positional audio program names only once

開放

#5,712 建立於 2022年6月1日

 (4 則留言) (2 個反應) (0 位負責人)C++ (1,062 個分叉)batch import
clientfeature-requestgood first issue

倉庫指標

星標
 (5,642 顆星)
PR 合併指標
 (平均合併 6天) (30 天內合併 7 個 PR)

描述

Context

Right now Mumble iterates through every program name of every PID for every positional audio plugin. This is quite wasted CPU time if either the PID count is high or plugin count is high, as the time complexity is in $\mathcal{O}(PIDNum \cdot pluginNum )$.

Example: https://github.com/mumble-voip/mumble/blob/dd5df45313a937359285327f556557159bab758e/plugins/gtav/gtav.cpp#L81

Description

A better solution would be if each plugin tells Mumble what program name it is looking for, so that only Mumble has to iterate over the PID-list once.

Mumble component

Client

OS-specific?

No

Additional information

This issue originated from https://github.com/mumble-voip/mumble/pull/5704#issuecomment-1141938952

貢獻者指南