mumble-voip/mumble

Connection Dialog Should Display Ping Issues (timeouts, packetloss)

Open

#3,158 建立於 2017年7月9日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)C++ (5,642 star) (1,062 fork)batch import
clientfeature-requesthelp wantedui

描述

I had internet connection issues the last two days and noticed the server stats are only updated on successful pings. That means that if you had 1 successful 30ms ping with user count and then none for 10 minutes the displayed info is 10 minutes old and wrong (/does not indicate connection issues).

If we start with timeouts we do not display anything. Maybe some negative feedback would be useful then as well (use case: user has only 1 favourite server; does not see that we ping unsuccessfully, connect button is greyed out).

貢獻者指南

技術棧
cpp
領域
desktop
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++Qt
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue requests that the connection dialog display indicators for ping failures (timeouts, packet loss) and not just rely on successful pings. To implement this, one would need to modify the ping handling logic in the Mumble client, likely in the files related to the connection dialog (e.g., `src/mumble/Connection.cpp` or similar). The current behavior only updates stats on successful pings, so the fix involves detecting and displaying failed pings, possibly by showing a 'Connection Lost' or latency graph with missing data points.