mumble-voip/mumble

Settings window should be non-modal, and the "Apply" button should apply settings immediately

Open

#2,734 建立於 2017年1月17日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)C++ (5,642 star) (1,062 fork)batch import
feature-requesthelp wantedui

描述

Hi I am on the latest v1.3 snapshot (64bit) and it appears that the apply button does not work as it should.

Simple steps to reproduce:

  1. Open Preferences
  2. Go to User Interface and change the "layout"
  3. Press apply

The new layout will not be applied until restart. However pressing "OK" works as it should and applies the setting correctly.

貢獻者指南

技術棧
cpp
領域
desktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Qt frameworkMumble build systemC++ basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue reports that the Apply button in the Preferences window does not apply layout changes immediately, unlike the OK button. Investigate the event handling for the Apply button in the settings dialog. Look at files like `src/mumble/Settings.cpp` or `src/mumble/Preferences.ui` to understand the current behavior. Compare with the OK button logic. Ensure that the Apply button triggers the same apply logic as OK without closing the dialog. Consider whether making the window non modal is necessary for expected behavior.
Settings window should be non-modal, and the "Apply" button should apply settings immediately · mumble-voip/mumble#2734 | Good First Issue