mozilla/webmaker-core

device photographs may end up with the wrong orientation

開放

#270 建立於 2015年7月14日

 (0 則留言) (0 個反應) (0 位負責人)JavaScript (31 個分叉)auto 404
androidenhancementhelp wanted

倉庫指標

星標
 (63 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

This issue has been migrated from mozilla/webmaker-android#2371.

It was originally written by Pomax on Tue Jun 30 2015 and had the following description:

taking an on-device picture can lead to taking a picture in portrait mode, but having webmaker-android add it to the page in landscape mode.

Perhaps we should add an orientation control, so we can do 90 degree turns clockwise/counter clockwise in the editor view, in addition to the far less precise finger rotation?

On Tue Jun 30 2015, xmatthewx commented:

:+1:

On Tue Jun 30 2015, thisandagain commented:

The OS should detect the orientation of the photo and return it appropriately. It seems to do this most of the time (confirming on a Nexus 5) but we likely have a missing edge-case. I'd rather fix it at the device level than add complexity to the page editor.

On Tue Jun 30 2015, xmatthewx commented:

Ah. Glad to hear it works on other devices. Doesn't work on my Sony. They have proprietary camera software you can't replace w/o root. I believe that Sony is getting out of the mobile business ( :confused: ), so I wouldn't hustle to fix it here.

Sony Xperia Z3C model D5803 Android 5.0.2

On Mon Jul 13 2015, ryanw-se commented:

I'm trying to think of the best way to tackle this issue, does anyone know if there is an existing implementation for setting the orientation of a photo? If there is I could easily add a JS interfacable method for retrieving the orientation of a photo, however I would need to conform the result to the current implementation (if there is any).

貢獻者指南