mozilla/testpilot

Refine .eslintrc rules for node vs browser JS

開放

#3,228 建立於 2018年1月10日

 (6 則留言) (0 個反應) (0 位負責人)FreeMarker (108 個分叉)auto 404
dev papercutgood first issueskill:js

倉庫指標

星標
 (250 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

As @pdehaan mentions:

What about just specifying the ESLint environment in the gulpfile.babel.js and webpack.config.js, a la /* eslint-env node, browser, whatever */. Or if we want to set the node env for a directory, we could just use a nested .eslintrc file (for tests or gulp tasks or whatnot).

We've got a pretty broad set of globals and envs covering all of our JS for linting, right now. But, some JS is for the build chain in node and some are for running in the browser. Might be nice to use per-directory & file glob eslint overrides to further focus what's allowed for various source files.

貢獻者指南