mozilla/send

[Send 2][Enhancement] Clicking inside the “Privacy” overlay should dismiss it

Open

#1,304 建立於 2019年4月22日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)JavaScript (13,154 star) (1,239 fork)batch import
[QA]:Enhancementgood first issueskill:js

描述

[Notes]:

  • There should be consistency regarding the dismissal of the overlay considering that the upload complete and Sign in/up overlays are dismissed when clicking inside them.

[Affected versions]:

  • Firefox 66.0.3 and up
  • Chrome Version 73.0

[Affected Platforms]:

  • All Mac
  • All Windows
  • All Linux

[Steps to reproduce]:

  1. Open the browser and navigate to the https://send.firefox.com/ website.
  2. Click the “Privacy” button.
  3. Click inside the overlay but not on any actionable buttons.

[Expected result]:

  • The overlay is dismissed.

[Actual result]:

  • The overlay is still displayed.

[Additional Notes]:

rec of issue - overlay dismissal

貢獻者指南

技術棧
javascripthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic JavaScriptFamiliarity with event handling in the browser
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue requires adding a click handler to dismiss the Privacy overlay when clicking inside it (but not on actionable buttons). Look at how other overlays (upload complete, sign in/up) handle dismissal for consistency. The codebase is likely JavaScript with HTML/CSS. Check the overlay component and its event listeners. Review the 6 comments on the issue for any additional context or attempted solutions.
[Send 2][Enhancement] Clicking inside the “Privacy” overlay should dismiss it · mozilla/send#1304 | Good First Issue