Change Alphabet::EncodeSingle and Alphabet::DecodeSingle to use an outparam and return an error code instead of calling `abort` · mozilla/DeepSpeech#3175

(14 留言) (0 反應) (0 負責人)C++ (26,755 star) (4,093 fork)batch import

buggood first bughelp wanted

描述

I run into the error "Invalid label 0". I assume it is from the function Alphabet::DecodeSingle() in the file native_client/alphabet.cc.

I don't know why I am running into this error and it is not important for now. What is important is the fact that the code calls abort() just after printing this error.

I don't know your guidelines. But I can tell that aborting the whole process, including the python interpreter which might be interactive, is a terrible way of handling errors, especially in such a trivial function, and I call it a bug.

貢獻者指南

技術棧: cpp
領域: machine learningbackend
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: mostly clear
前置要求: basic C++error handling
新手友善度: 65
研究方向: The issue proposes changing `Alphabet::EncodeSingle` and `Alphabet::DecodeSingle` in `native client/alphabet.cc` to return an error code via an out parameter and avoid calling `abort`. The current implementation aborts the process on invalid labels. The change requires updating the function signatures in the header `native client/alphabet.h`, modifying the implementation, and adjusting all callers to handle the error status. The specific error code type and convention (e.g., bool, enum, or integer) need to be determined based on existing patterns in the codebase. Check comments in the issue for any maintainer guidance or alternative approaches.