moroshko/react-autosuggest

Warning about `componentWillReceiveProps` in React's Strict Mode

Open

#624 建立於 2019年3月16日

在 GitHub 查看
 (9 留言) (54 反應) (0 負責人)JavaScript (5,936 star) (637 fork)batch import
help wanted

描述

React's Strict Mode warns about "Unsafe lifecycle methods were found within a strict-mode tree".

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead.

https://github.com/moroshko/react-autosuggest/blob/d626cef720df0ed5a4c7df4d539836b86bda6afa/src/Autosuggest.js#L124-L143

貢獻者指南

技術棧
reactjavascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React lifecycle methods
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The issue is to update the Autosuggest component to replace the deprecated `componentWillReceiveProps` lifecycle method with `getDerivedStateFromProps` as per React's Strict Mode warning. The relevant code is in `src/Autosuggest.js` around lines 124-143. The fix should follow React's official documentation on migrating from legacy lifecycle methods. No additional changes are required.